Open
Conversation
jordandrako
suggested changes
Jun 16, 2020
| } | ||
|
|
||
| export interface ResponsivePropsConfig { | ||
| propKeys: Array<string>; |
There was a problem hiding this comment.
Array<T> is used a couple times in this PR, but it's generally better to use T[].
| thresholdMap: PropTypes.object, | ||
| /** @ignore */ | ||
| children: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.node), PropTypes.node]).isRequired | ||
| children: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.node), PropTypes.node]).isRequired, |
There was a problem hiding this comment.
Shouldn't propTypes be replaced with interfaces?
Author
There was a problem hiding this comment.
Technically they are not identical and still have value in non-TS apps. I was trying to change as little functionality as possible in this PR.
| "esModuleInterop": true, | ||
| "preserveSymlinks": true, | ||
| "baseUrl": ".", | ||
| "outDir": "./dist" |
There was a problem hiding this comment.
Does this build to both common-js and es-modules?
Co-authored-by: Jordan Janzen <jordancjanzen@gmail.com>
Co-authored-by: Jordan Janzen <jordancjanzen@gmail.com>
Co-authored-by: Jordan Janzen <jordancjanzen@gmail.com>
Co-authored-by: Jordan Janzen <jordancjanzen@gmail.com>
jordandrako
approved these changes
Jun 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added config to build and test Typescript.
Converted src to TS (but not the tests yet).