[codex] Fix stable clippy sort lint#1711
Draft
patrik-sandin wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This isolates the stable clippy fix for
metadata/src/audio/item.rsinto its own PR.The change replaces a
sort_bycall withsort_by_key(Reverse(...))to satisfyclippy::unnecessary_sort_byon the stable toolchain without changing behavior.Why
While validating #1708, stable clippy surfaced a repository-wide lint in
metadata/src/audio/item.rsthat was unrelated to the Avahi fix. Keeping this as a separate PR keeps the Avahi bugfix narrow and makes the lint cleanup easier to review.Validation
cargo clippy -p librespot-metadata --lib -- -D warningscargo fmt --check