chore(strict): P28 chatgpt-model ts-check + typedefs (DOM tsconfig)#29
Merged
Conversation
Annotate web-ai/chatgpt-model.mjs (603 lines) with // @ts-check, ModelChoice and EffortChoice unions, Record types on aliases/options/efforts, full JSDoc on 7 exports + 14 helpers, and HTMLElement casts inside page.evaluate callbacks. Goes in tsconfig.checkjs-dom.json. No runtime change. contract-audit / action-intent / target-resolver once chatgpt-composer is annotated next. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VERDICT-B per-file ts-check on web-ai/chatgpt-model.mjs (603 lines, pure leaf). Goes into tsconfig.checkjs-dom.json because page.evaluate callbacks reference DOM types.
Changes: // @ts-check, ModelChoice/EffortChoice unions, Record<> typings on alias/option/effort tables, JSDoc on 7 exports + 14 helpers, HTMLElement casts inside page.evaluate callbacks for innerText.
No runtime change: no Boolean/String/Number wrappers, no new ?., no fallbacks added/removed.
Gates: tsc -p tsconfig.checkjs-dom.json OK, tsc -p tsconfig.checkjs.json OK, tsc --noEmit OK, check:strict-baseline OK.