P49: strict checkjs for web-ai/gemini-live.mjs#51
Merged
Conversation
VERDICT-B (per-file // @ts-check + JSDoc, no runtime change). - Add // @ts-check + typedef block (Deps/Input/Page = any) - JSDoc @param {any} on every named function - Inline /** @type {any} */ casts on: - defineCapability arrow callbacks - page.evaluate destructure params - shadowRoot target.value access (Element vs HTMLInputElement) - caught error e.message access (no new runtime binding) - .catch(e =>) callback param - copied.status on CaptureCopyResult union - WebAiSession -> FinalizeSession at finalizeProviderTab call - .map(file => contextPack iteration - usedFallbacks let typed as any[] - Append web-ai/gemini-live.mjs to tsconfig.checkjs-dom.json All 4 gates green: tsc-dom, tsc-node, node --check, npm test (473 passed). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lidge-jun
force-pushed
the
chore/strict-migration-p49
branch
from
ed1b2b5 to
adc0117
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VERDICT-B per-file // @ts-check + JSDoc; appended to tsconfig.checkjs-dom.json. No runtime change. 4 gates green (473 tests pass).