Feat: adds linking multiple folders

[l-mansouri]

Overview

This PR implements the possibility to link multiple folders in one go to running interactive sessions. It works both with s3 paths and file explorer folders.

JIRA

Please add here as many related tasks this PR covers with its brief description, if more than one ticket

https://lifebit.atlassian.net/browse/LP-107740

Changes

• Implements linking of multiple folders with 1 command

Acceptance Criteria

Please add here as many scenarios as in the Story

DEV

link multiple folders from file explorer

cloudos link --profile internal-DEV --session-id 69f1c7f2434c9867c5e2b384 Data/results,Data/concat_output

link multiple folders from file explorer when creating the interactive session

``` cloudos interactive-session create --name test_link --session-type vscode --link Data/results,Data/concat_output --profile internal-DEV ```

link multiple s3 path

cloudos link --session-id 69f1c7f2434c9867c5e2b384 s3://lifebit-featured-datasets/pipelines/vep/agg_vcf/,s3://lifebit-featured-datasets/pipelines/phewas/example-data/,s3://lifebit-featured-datasets/pipelines/lifebit-platform-target-identification/test_data/ --profile internal-DEV

link multiple folders from s3 paths when creating the interactive session

cloudos interactive-session create --name test_link --session-type vscode --link s3://lifebit-featured-datasets/pipelines/vep/agg_vcf/,s3://lifebit-featured-datasets/pipelines/phewas/example-data/,s3://lifebit-featured-datasets/pipelines/lifebit-platform-target-identification/test_data/ --profile internal-DEV

[danielboloc]

Thanks @l-mansouri

I have used an agent to do a review, so I have added the most important comments from the review as suggested changes and added my own.

[danielboloc]

Thanks @l-mansouri

LGTM

[dapineyro]

@l-mansouri , already seen in the second AC from the PR description:

The linked folders from File Explorer appear with a wrong S3 path. You could add a specific "Linked from File Explorer" instead

[dapineyro]

@l-mansouri I've noticed three unexpected behaviours:

First unexpected

With the following command:

cloudos interactive-session create --name test_linking --session-type jupyter --link davidp_testing/Data/test_folder_1/results,davidp_testing/Data/test_folder_2/results

Being these two folders existing folders, but empty:

It successfully creates the session, but both links are failed with the following (suggesting my project does not exist, but it does):

Second unexpected

With the following command attempting to link two different job results folders:

cloudos interactive-session create --name test_linking --session-type jupyter --link s3://lifebit-user-data-ef05b3b1-3351-4b12-bafd-0515724bb2a8/deploit/teams/687fb9905c45270e09db1e9a/users/6329e3bd3c0e00014641eeea/projects/69f371a716f1efef6773c258/jobs/69f8c2de21209be1c3222789/results/results/,s3://lifebit-user-data-ef05b3b1-3351-4b12-bafd-0515724bb2a8/deploit/teams/687fb9905c45270e09db1e9a/users/6329e3bd3c0e00014641eeea/projects/69f371a716f1efef6773c258/jobs/69f8aff021209be1c3220bd0/results/results/

It does not complain, it let you create the session, but only one results folder is actually linked (even if it seems it linked both):

Third unexpected

Actually, the command does not check for the existence of your linked folders. It goes straight to the instance creation and then the user will find weird errors for the mounted folders. If the user did an unnoticed typo, it will lead to a ticket that we could avoid by checking. Is it possible to check for the existence of the folders, at least the File Explorer ones?

[l-mansouri]

@dapineyro I have addressed all your comments

For point 1, the issue is not that they were empty but that they were virtual folders that can't be linked

For point 2 and 3 there are a couple of issues stacked: multiple folders with the same name that can't be linked and the fact that the mounting only happen after the session is created so there are natively no checks on it up until the session is started. I have added a check of existence for file explorer paths and a duplicated name check

[l-mansouri]

the new help text

[dapineyro]

LGTM!