Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the build process to target Scala Native instead of GraalVM. This involves updating the Dockerfile to install libcurl4-openssl-dev and switch to Scala Native packaging, as well as modifying project.scala to configure Scala Native and adjust dependencies. Review feedback highlights a critical issue with the upickle dependency in project.scala, where version 4.4.2 is non-existent and should be corrected to 3.3.1 to prevent build failures. An improvement is also suggested for the Dockerfile to use --no-install-recommends with apt-get install to optimize image size.
| //> using toolkit default | ||
| //> using dep "com.softwaremill.sttp.client4::core:4.0.0-M14" | ||
| //> using dep "com.lihaoyi::upickle:3.3.1" | ||
| //> using dep "com.lihaoyi::upickle:4.4.2" |
There was a problem hiding this comment.
The upickle dependency is set to version 4.4.2, which does not appear to be a published version. The latest known version is 3.3.1. Using a non-existent version will cause a dependency resolution failure and break the build. Please correct the version to a valid one.
| //> using dep "com.lihaoyi::upickle:4.4.2" | |
| //> using dep "com.lihaoyi::upickle:3.3.1" |
| @@ -1,14 +1,16 @@ | |||
| FROM virtuslab/scala-cli:latest as build-image | |||
|
|
|||
| RUN apt-get update && apt-get install -y libcurl4-openssl-dev && rm -rf /var/lib/apt/lists/* | |||
There was a problem hiding this comment.
#14