Skip to content

Scala Native#18

Merged
limit7412 merged 5 commits into
masterfrom
develop
Apr 9, 2026
Merged

Scala Native#18
limit7412 merged 5 commits into
masterfrom
develop

Conversation

@limit7412
Copy link
Copy Markdown
Owner

@limit7412 limit7412 commented Apr 9, 2026

devin-ai-integration[bot]

This comment was marked as resolved.

@limit7412 limit7412 merged commit 995f287 into master Apr 9, 2026
2 checks passed
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the build process to target Scala Native instead of GraalVM. This involves updating the Dockerfile to install libcurl4-openssl-dev and switch to Scala Native packaging, as well as modifying project.scala to configure Scala Native and adjust dependencies. Review feedback highlights a critical issue with the upickle dependency in project.scala, where version 4.4.2 is non-existent and should be corrected to 3.3.1 to prevent build failures. An improvement is also suggested for the Dockerfile to use --no-install-recommends with apt-get install to optimize image size.

Comment thread project.scala
//> using toolkit default
//> using dep "com.softwaremill.sttp.client4::core:4.0.0-M14"
//> using dep "com.lihaoyi::upickle:3.3.1"
//> using dep "com.lihaoyi::upickle:4.4.2"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The upickle dependency is set to version 4.4.2, which does not appear to be a published version. The latest known version is 3.3.1. Using a non-existent version will cause a dependency resolution failure and break the build. Please correct the version to a valid one.

Suggested change
//> using dep "com.lihaoyi::upickle:4.4.2"
//> using dep "com.lihaoyi::upickle:3.3.1"

Comment thread Dockerfile
@@ -1,14 +1,16 @@
FROM virtuslab/scala-cli:latest as build-image

RUN apt-get update && apt-get install -y libcurl4-openssl-dev && rm -rf /var/lib/apt/lists/*
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To minimize the Docker image layer size and avoid installing unnecessary packages, it's a good practice to use the --no-install-recommends flag with apt-get install.

RUN apt-get update && apt-get install -y --no-install-recommends libcurl4-openssl-dev && rm -rf /var/lib/apt/lists/*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant