Skip to content

Merge upstream for WebKNOSSOS#28

Draft
aaronkanzer wants to merge 47 commits into
ak-scalableminds-masterfrom
ak-merge-upstream-nov26
Draft

Merge upstream for WebKNOSSOS#28
aaronkanzer wants to merge 47 commits into
ak-scalableminds-masterfrom
ak-merge-upstream-nov26

Conversation

@aaronkanzer

Copy link
Copy Markdown

fm3 and others added 30 commits October 30, 2024 12:54
* Allow downloading tasks of teams you are not in

* changelog

* fix error msg
…calableminds#8164)

* allow to delete bbox even if there is no visible segmentation layer

* add changelog
Co-authored-by: Charlie Meister <charlie.meister@student.hpi.de>
)

* always run artifact upload for nightly tests

* add browserstack session ID to every test run

* upgrade uplad-artifact action to v4
…minds#8173)

* Change long unit name in frontend from ångström to angstrom

The backend uses "angstrom", which is consistent with ngff, compare https://ngff.openmicroscopy.org/latest/#axes-md – so the frontend needs to send the same.

* add changelog entry

---------

Co-authored-by: Michael Büßemeyer <frameworklinux+MichaelBuessemeyer@users.noreply.github.com>
update open source installation link
…scalableminds#8179)

Co-authored-by: Michael Büßemeyer <frameworklinux+MichaelBuessemeyer@users.noreply.github.com>
* add option to select annotation state in time tracking overview

* include annotation state in user specific time tracking csv download

* show full long project names in timetracking filter input

* fix tests

* update timetracking snapshots

* fix cyclic frontend dependencies

* move AnnotationTypeFilterEnum and  AnnotationStateFilterEnum to constants and increase constant width of timetracking filter dropdown

* add missing changes of last commit

* mend

* Update frontend/javascripts/admin/statistic/project_and_annotation_type_dropdown.tsx

Co-authored-by: Daniel <daniel.werner@scalableminds.com>

---------

Co-authored-by: Michael Büßemeyer <frameworklinux+MichaelBuessemeyer@users.noreply.github.com>
Co-authored-by: Daniel <daniel.werner@scalableminds.com>
* Wrap antd tree to enable scrolling while dragging

* add explanation to biome ignore comment

* add changelog entry

* fix typing

* extract magic numbers into constants

* apply feedback
- send datasource id in correct format to backend
- fix dataset renaming in dataset settings
- fix typo in filename

---------

Co-authored-by: Michael Büßemeyer <frameworklinux+MichaelBuessemeyer@users.noreply.github.com>
* make button bar flexbox

* remove unnessecary scrollbars

* line break group names

* style buttons

* remove stand-alone style

* add changelog

* adress review
… oblique mode (scalableminds#8177)

* Fix layout persistence when switching between orthogonal, flight, and oblique mode

* update changelog

* Apply suggestions from code review

Co-authored-by: MichaelBuessemeyer <39529669+MichaelBuessemeyer@users.noreply.github.com>

---------

Co-authored-by: MichaelBuessemeyer <39529669+MichaelBuessemeyer@users.noreply.github.com>
* fix that createNodeAction got wrong param

* add changelog

* undo edit of MutableNode type

* fix typo

* fix reducer tests

---------

Co-authored-by: Michael Büßemeyer <frameworklinux+MichaelBuessemeyer@users.noreply.github.com>
* use forwardRef for scrollable virtualized tree

* add changelog entry

---------

Co-authored-by: Michael Büßemeyer <frameworklinux+MichaelBuessemeyer@users.noreply.github.com>
…lableminds#8187)

* fix server node type by switching back to mag

* add changelog entry

---------

Co-authored-by: Michael Büßemeyer <frameworklinux+MichaelBuessemeyer@users.noreply.github.com>
…ableminds#8176)

* Fix performance bottleneck when deleting a lot of trees at once.

Also fix a bug when importing an NML with groups when only groups but no trees exist in an annotation.
Also fix a bug where trying to delete a non-existing node (via the API, for example) would delete the whole active tree.

* update changelog

* apply PR feedback

* Better error message for non-existing key in diffable map and don't throw an error in getNodeAndTree if a node with nodeId does not exist.
…ableminds#8195)

* Exploring remote datasets: drop neuroglancer prefixes from URIs

* changelog
…minds#8200)

* do not restrict bbox size for inferal jobs for super user

* add changelog entry

---------

Co-authored-by: Michael Büßemeyer <frameworklinux+MichaelBuessemeyer@users.noreply.github.com>
Co-authored-by: Florian M <fm3@users.noreply.github.com>
* Remove Google Analytics

* changelog, migration guide

* Update CHANGELOG.unreleased.md

Co-authored-by: Daniel <daniel.werner@scalableminds.com>

---------

Co-authored-by: Daniel <daniel.werner@scalableminds.com>
@kabilar

kabilar commented Apr 29, 2025

Copy link
Copy Markdown
Member

Hi @aaronkanzer, I think we need to prioritize merging commits from upstream. The ability to modify the View Mode after the annotation is created has been fixed upstream. I tested this feature in the webknossos.org trial account. Thank you.

cc @satra

@aaronkanzer

Copy link
Copy Markdown
Author

Hi @aaronkanzer, I think we need to prioritize merging commits from upstream. The ability to modify the View Mode after the annotation is created has been fixed upstream. I tested this feature in the webknossos.org trial account. Thank you.

cc @satra

Thanks @kabilar for noting -- I'll work on a rebase once I'm back from the OME Community Meeting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants