Skip to content

Reduce metadata refresh retries from 20 to 3 #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiang95-dev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Reduce metadata refresh retries from 20 to 3 #576

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1585ff1
Reduce metadata refresh retries from 20 to 3
jiang95-dev May 11, 2026
8cd8111
fix
jiang95-dev May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ...c/main/java/com/linkedin/openhouse/internal/catalog/OpenHouseInternalTableOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,13 @@ public class OpenHouseInternalTableOperations extends BaseMetastoreTableOperatio
private static final Cache<String, Integer> CACHE =
CacheBuilder.newBuilder().expireAfterWrite(5, TimeUnit.MINUTES).maximumSize(1000).build();

/**
* Overrides Iceberg's {@code BaseMetastoreTableOperations.META_DATA_REFRESH_RETRIES} (20). The
* underlying {@code refreshFromMetadataLocation} retries with exponential backoff capped at 5s,
* so 20 retries can stretch a single failing refresh to ~90 seconds.
*/
private static final int METADATA_REFRESH_RETRIES = 3;

@Override
protected String tableName() {
return this.tableIdentifier.toString();
Expand Down Expand Up @@ -133,7 +140,7 @@ protected void doRefresh() {
protected void refreshMetadata(final String metadataLoc) {
long startTime = System.currentTimeMillis();
boolean needToReload = !Objects.equal(currentMetadataLocation(), metadataLoc);
Runnable r = () -> super.refreshFromMetadataLocation(metadataLoc);
Runnable r = () -> super.refreshFromMetadataLocation(metadataLoc, METADATA_REFRESH_RETRIES);
try {
if (needToReload) {
metricsReporter.executeWithStats(
Expand Down Expand Up @@ -405,7 +412,7 @@ updatedMtDataRef, io().newOutputFile(newMetadataLocation)),
* "forced refresh" in {@link OpenHouseInternalTableOperations#commit(TableMetadata,
* TableMetadata)}
*/
refreshFromMetadataLocation(newMetadataLocation);
refreshFromMetadataLocation(newMetadataLocation, METADATA_REFRESH_RETRIES);
}
if (isReplicatedTableCreate(properties)) {
updateMetadataFieldForTable(metadata, newMetadataLocation);
Expand Down