Skip to content

Make NodePool optional for LKE-E in python sdk #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ezilber-akamai merged 7 commits into from
Jan 16, 2026
+71 −12
Merged

Make NodePool optional for LKE-E in python sdk #630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a6f0b01
Merge pull request #611 from linode/dev
ezilber-akamai Oct 7, 2025
fecccdb
Merge pull request #616 from linode/dev
zliang-akamai Oct 29, 2025
c5fc286
make nodepools optional in cluster_create
rammanoj Jan 5, 2026
e882652
Merge branch 'dev' of https://github.com/linode/linode_api4-python in…
rammanoj Jan 5, 2026
d3300d9
Update linode_api4/groups/lke.py
rammanoj Jan 5, 2026
966859c
address feedback
rammanoj Jan 13, 2026
9ff2e33
Merge branch 'dev' into optional-nodepools
rammanoj Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion linode_api4/groups/lke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ def cluster_create(
self,
region,
label,
node_pools,
kube_version,
node_pools: Optional[list] = None,
control_plane: Union[
LKEClusterControlPlaneOptions, Dict[str, Any]
] = None,
Expand Down Expand Up @@ -119,6 +119,15 @@ def cluster_create(
:returns: The new LKE Cluster
:rtype: LKECluster
"""
if node_pools is None:
node_pools = []

if len(node_pools) == 0 and (
tier is None or tier.lower() != "enterprise"
):
raise ValueError(
"LKE standard clusters must have at least one node pool."
)
Comment on lines +122 to +130
Copy link
Member

@zliang-akamai zliang-akamai Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we would delay validation like this to the API in SDKs implementation lol, but it's fine here as is.


params = {
"label": label,
Expand Down
2 changes: 1 addition & 1 deletion test/integration/linode_client/test_linode_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,8 +354,8 @@ def test_fails_to_create_cluster_with_invalid_version(test_linode_client):
cluster = client.lke.cluster_create(
region,
"example-cluster",
{"type": "g6-standard-1", "count": 3},
invalid_version,
{"type": "g6-standard-1", "count": 3},
)
except ApiError as e:
assert "not valid" in str(e.json)
Expand Down
10 changes: 5 additions & 5 deletions test/integration/models/lke/test_lke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def lke_cluster(test_linode_client):
label = get_test_label() + "_cluster"

cluster = test_linode_client.lke.cluster_create(
region, label, node_pools, version
region, label, version, node_pools
)

yield cluster
Expand All @@ -57,8 +57,8 @@ def lke_cluster_with_acl(test_linode_client):
cluster = test_linode_client.lke.cluster_create(
region,
label,
node_pools,
version,
node_pools,
control_plane=LKEClusterControlPlaneOptions(
acl=LKEClusterControlPlaneACLOptions(
enabled=True,
Expand Down Expand Up @@ -103,7 +103,7 @@ def lke_cluster_with_labels_and_taints(test_linode_client):
label = get_test_label() + "_cluster"

cluster = test_linode_client.lke.cluster_create(
region, label, node_pools, version
region, label, version, node_pools
)

yield cluster
Expand All @@ -124,8 +124,8 @@ def lke_cluster_with_apl(test_linode_client):
cluster = test_linode_client.lke.cluster_create(
region,
label,
node_pools,
version,
node_pools,
control_plane=LKEClusterControlPlaneOptions(
high_availability=True,
),
Expand Down Expand Up @@ -160,8 +160,8 @@ def lke_cluster_enterprise(e2e_test_firewall, test_linode_client):
cluster = test_linode_client.lke.cluster_create(
region,
label,
node_pools,
version,
node_pools,
tier="enterprise",
)

Expand Down
52 changes: 51 additions & 1 deletion test/unit/groups/lke_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ def test_cluster_create_with_acl(self):
self.client.lke.cluster_create(
"us-mia",
"test-acl-cluster",
[self.client.lke.node_pool("g6-nanode-1", 3)],
"1.29",
[self.client.lke.node_pool("g6-nanode-1", 3)],
control_plane=LKEClusterControlPlaneOptions(
acl=LKEClusterControlPlaneACLOptions(
enabled=True,
Expand All @@ -41,3 +41,53 @@ def test_cluster_create_with_acl(self):
assert m.call_data["control_plane"]["acl"]["addresses"]["ipv6"] == [
"1234::5678"
]

def test_cluster_create_enterprise_without_node_pools(self):
"""
Tests that an enterprise LKE cluster can be created without node pools.
"""
with self.mock_post("lke/clusters") as m:
self.client.lke.cluster_create(
"us-west",
"test-enterprise-cluster",
"1.29",
tier="enterprise",
)

assert m.call_data["region"] == "us-west"
assert m.call_data["label"] == "test-enterprise-cluster"
assert m.call_data["k8s_version"] == "1.29"
assert m.call_data["tier"] == "enterprise"
assert m.call_data["node_pools"] == []

def test_cluster_create_enterprise_case_insensitive(self):
"""
Tests that tier comparison is case-insensitive for enterprise tier.
"""
with self.mock_post("lke/clusters") as m:
self.client.lke.cluster_create(
"us-west",
"test-enterprise-cluster",
"1.29",
tier="ENTERPRISE",
)

assert m.call_data["tier"] == "ENTERPRISE"
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test validates case-insensitive tier comparison in the validation logic, but the assertion checks that the tier is passed through as-is to the API. Consider also asserting that node_pools is empty to ensure the validation logic correctly allows enterprise clusters without node pools regardless of case.

Copilot uses AI. Check for mistakes.
assert m.call_data["node_pools"] == []

def test_cluster_create_standard_without_node_pools_raises_error(self):
"""
Tests that creating a standard LKE cluster without node pools raises ValueError.
"""
with self.assertRaises(ValueError) as context:
self.client.lke.cluster_create(
"us-east",
"test-standard-cluster",
"1.29",
tier="standard",
)

self.assertIn(
"LKE standard clusters must have at least one node pool",
str(context.exception),
)
4 changes: 2 additions & 2 deletions test/unit/linode_client_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,7 +817,7 @@ def test_cluster_create_with_api_objects(self):
node_pools = self.client.lke.node_pool(node_type, 3)
with self.mock_post("lke/clusters") as m:
cluster = self.client.lke.cluster_create(
region, "example-cluster", node_pools, version
region, "example-cluster", version, node_pools
)
self.assertEqual(m.call_data["region"], "ap-west")
self.assertEqual(
Expand Down Expand Up @@ -850,8 +850,8 @@ def test_cluster_create_with_string_repr(self):
cluster = self.client.lke.cluster_create(
"ap-west",
"example-cluster",
{"type": "g6-standard-1", "count": 3},
"1.19",
{"type": "g6-standard-1", "count": 3},
)
self.assertEqual(m.call_data["region"], "ap-west")
self.assertEqual(
Expand Down
4 changes: 2 additions & 2 deletions test/unit/objects/lke_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,7 @@ def test_cluster_create_with_labels_and_taints(self):
self.client.lke.cluster_create(
"us-mia",
"test-acl-cluster",
"1.29",
[
self.client.lke.node_pool(
"g6-nanode-1",
Expand All @@ -317,7 +318,6 @@ def test_cluster_create_with_labels_and_taints(self):
],
)
],
"1.29",
)

assert m.call_data["node_pools"][0] == {
Expand All @@ -339,13 +339,13 @@ def test_cluster_create_with_apl(self):
cluster = self.client.lke.cluster_create(
"us-mia",
"test-aapl-cluster",
"1.29",
[
self.client.lke.node_pool(
"g6-dedicated-4",
3,
)
],
"1.29",
apl_enabled=True,
control_plane=LKEClusterControlPlaneOptions(
high_availability=True,
Expand Down