Skip to content

fix(db): prevent duplicate member segment affiliations #3985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prembharne wants to merge 4 commits into
base: main
Choose a base branch
from
+32 −0
Open

fix(db): prevent duplicate member segment affiliations #3985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffba34f
fix(db): prevent duplicate member segment affiliations
prembharne Mar 31, 2026
911022f
fix(db): correct timestamptz type in unique index sentinel values
prembharne Mar 31, 2026
83d7477
fix(db): use atomic INSERT ON CONFLICT instead of SELECT-then-INSERT
prembharne Mar 31, 2026
78f029e
Merge branch 'main' into main
prembharne Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions backend/src/database/migrations/V1775000000__fix-member-segment-affiliations.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
-- 1. Deduplicate existing memberSegmentAffiliations
DELETE FROM "memberSegmentAffiliations" a USING (
SELECT MIN(id) as keep_id, "memberId", "segmentId", "organizationId", "dateStart", "dateEnd"
FROM "memberSegmentAffiliations"
GROUP BY "memberId", "segmentId", "organizationId", "dateStart", "dateEnd"
HAVING COUNT(*) > 1
) b
WHERE a."memberId" = b."memberId"
AND a."segmentId" = b."segmentId"
AND a."organizationId" IS NOT DISTINCT FROM b."organizationId"
AND a."dateStart" IS NOT DISTINCT FROM b."dateStart"
AND a."dateEnd" IS NOT DISTINCT FROM b."dateEnd"
AND a.id <> b.keep_id;

-- 2. Add an index to prevent exact duplicates in the future
-- Using COALESCE ensures that NULL values are logically treated as equal
-- across all supported PostgreSQL versions for the sake of uniqueness.
CREATE UNIQUE INDEX "uq_member_segment_affiliations" ON "memberSegmentAffiliations" (
"memberId",
"segmentId",
COALESCE("organizationId", '00000000-0000-0000-0000-000000000000'::uuid),
COALESCE("dateStart", '1970-01-01T00:00:00Z'::timestamptz),
COALESCE("dateEnd", '1970-01-01T00:00:00Z'::timestamptz)
);
8 changes: 8 additions & 0 deletions backend/src/database/repositories/memberSegmentAffiliationRepository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,14 @@ class MemberSegmentAffiliationRepository extends RepositoryBase<
`INSERT INTO "memberSegmentAffiliations" ("id", "memberId", "segmentId", "organizationId", "dateStart", "dateEnd")
VALUES
(:id, :memberId, :segmentId, :organizationId, :dateStart, :dateEnd)
ON CONFLICT (
"memberId",
"segmentId",
COALESCE("organizationId", '00000000-0000-0000-0000-000000000000'::uuid),
COALESCE("dateStart", '1970-01-01T00:00:00Z'::timestamptz),
COALESCE("dateEnd", '1970-01-01T00:00:00Z'::timestamptz)
)
DO UPDATE SET "organizationId" = EXCLUDED."organizationId"
RETURNING "id"
`,
{
Expand Down