Add opt-in acoustic echo cancellation to Swift WakeWordListener#84
Closed
rajan9519 wants to merge 1 commit into
Closed
Add opt-in acoustic echo cancellation to Swift WakeWordListener#84rajan9519 wants to merge 1 commit into
rajan9519 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an opt-in
echoCancellationflag to the SwiftWakeWordListener.Why
WakeWordListenercaptures raw microphone audio, so anything the device isplaying out — e.g. an assistant's own TTS — bleeds into the detection window
and can trigger false positives.
How
echoCancellation: Bool = falseinit parameter. Whentrue, the mic isrouted through the platform's voice-processing I/O unit
(
setVoiceProcessingEnabled(true)), which references the device output andsubtracts it from the captured signal.
changes the node's format.
.measurementto.voiceChat, because.measurementdisables system signal processing including AEC.start()throws the newWakeWordError.echoCancellationUnavailablerather than silently capturing rawaudio, so callers that opted in aren't misled.
Compatibility
Default is
false, so existing callers are unchanged. No public API removed.Testing
swift buildandswift testpass (7 tests, 3 pre-existing skips). ThePython-only CI is unaffected.