Skip to content

Consolidating track-related logs #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexlivekit merged 2 commits into from
May 12, 2026
+9 −9
Merged

Consolidating track-related logs #677

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b24d3a0
changing some tarck* logs
alexlivekit May 6, 2026
99b318e
proper time keeping
alexlivekit May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions pkg/sip/room.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ package sip

import (
"context"
"errors"
"io"
"math"
"sync"
Expand All @@ -25,6 +24,7 @@ import (

"github.com/frostbyte73/core"
"github.com/pion/webrtc/v4"
"github.com/pkg/errors"

msdk "github.com/livekit/media-sdk"
"github.com/livekit/media-sdk/dtmf"
Expand Down Expand Up @@ -336,19 +336,19 @@ func (r *Room) Connect(ctx context.Context, conf *config.Config, rconf RoomConfi
r.subscribeTo(pub, rp)
},
OnTrackSubscribed: func(track *webrtc.TrackRemote, pub *lksdk.RemoteTrackPublication, rp *lksdk.RemoteParticipant) {
log := r.roomLog.WithValues("participant", rp.Identity(), "participantID", rp.SID(), "trackID", track.ID(), "trackName", pub.Name())
if !r.ready.IsBroken() {
log.Warnw("ignoring track, room not ready", nil)
return
}
log.Infow("mixing track")

go func() {
subscribedAt := time.Now().UnixMilli()
log := r.roomLog.WithValues("participant", rp.Identity(), "participantID", rp.SID(), "trackID", track.ID(), "trackName", pub.Name(), "subscribedAt", subscribedAt)
if !r.ready.IsBroken() {
log.Warnw("ignoring track, room not ready", nil)
return
}
defer func() { log.Infow("track closed", "closedAt", time.Now().UnixMilli()) }()

mTrack := r.NewTrack()
if mTrack == nil {
return // closed
}
defer log.Infow("track closed")
defer mTrack.Close()

var out msdk.PCM16Writer = mTrack
Expand Down
Loading