Skip to content

Finished#2

Open
dmtrxw wants to merge 7 commits into
lively-fox-2017:masterfrom
dmtrxw:master
Open

Finished#2
dmtrxw wants to merge 7 commits into
lively-fox-2017:masterfrom
dmtrxw:master

Conversation

@dmtrxw
Copy link
Copy Markdown

@dmtrxw dmtrxw commented Oct 16, 2017

No description provided.

@tamatamvan
Copy link
Copy Markdown

sedikit review, bagian secret key nya mungkin bisa di save ke file .env (dan file ini di git ignore) pakai library dotenv. but overall dah ok. tamvan approved 👍

@dmtrxw
Copy link
Copy Markdown
Author

dmtrxw commented Oct 16, 2017

@tamatamvan Sip thank u Mas Tama!

Btw kalau aku pakai .env berarti ke-"load" di local aja ya mas? (karena di git ignore), terus waktu di production aku harus kayak gini? :
process.env.SECRET_KEY || 'default_value'

atau gimana ya?

@tamatamvan
Copy link
Copy Markdown

tamatamvan commented Oct 16, 2017

bisa diakalin kayak gitu, sesuai kebutuhan aja intinya. tujuan kita pakai file .env emg supaya secret key yg bersifat sensitive ga ke expose sama org lain, dan file .env itu kan emg kepake buat development mode aja. biasanya kalau kita udah deploy kita akan atur ulang lagi value dari environment variable yg kita butuhin di sistem atau server production kita.

biasanya setiap platform kayak heroku, aws, gcp, dll punya petunjuk atau cara masing2 buat set env variable. contoh buat heroku seperti ini.

https://en.wikipedia.org/wiki/Environment_variable

@dmtrxw
Copy link
Copy Markdown
Author

dmtrxw commented Oct 16, 2017

oh yayaya, thanks mas...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants