Skip to content

Done#3

Open
jasoneffendi wants to merge 5 commits into
lively-fox-2017:masterfrom
jasoneffendi:master
Open

Done#3
jasoneffendi wants to merge 5 commits into
lively-fox-2017:masterfrom
jasoneffendi:master

Conversation

@jasoneffendi
Copy link
Copy Markdown

Heroku Deploy

@tamatamvan
Copy link
Copy Markdown

tamatamvan commented Oct 16, 2017

sedikit saran, mungkin ada baiknya methods untuk check login dan check admin dipisah file untuk membedakan function module api user yg utama sama yg berupa helpers/middleware.

terus untuk response yg dibalikin ketika berhasil login, register, add user, delete, update user, atau methods apapun itu kalau bisa jangan cuma ngembaliin message semacem "delete user success". kasih tau juga user yg nge-akses api kita data mana yg berhasi kita manipulasi. ada baik nya juga setiap response itu dibungkus dalam object biar lebih gampang manipulasi ketika udah masuk front-end nanti. contoh :

res.send({
  message: 'Insert user success',
  dataInserted: {
    username: 'tamvan',
    password: 'asbdoasvdiuaskj'
  }
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants