Done#3
Open
jasoneffendi wants to merge 5 commits into
Open
Conversation
|
sedikit saran, mungkin ada baiknya methods untuk check login dan check admin dipisah file untuk membedakan function module api user yg utama sama yg berupa helpers/middleware. terus untuk response yg dibalikin ketika berhasil login, register, add user, delete, update user, atau methods apapun itu kalau bisa jangan cuma ngembaliin message semacem "delete user success". kasih tau juga user yg nge-akses api kita data mana yg berhasi kita manipulasi. ada baik nya juga setiap response itu dibungkus dalam object biar lebih gampang manipulasi ketika udah masuk front-end nanti. contoh : res.send({
message: 'Insert user success',
dataInserted: {
username: 'tamvan',
password: 'asbdoasvdiuaskj'
}
}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heroku Deploy