Refactor suffix rendering logic in flux:menu.item component#2630
Open
ghabriel25 wants to merge 1 commit into
Open
Refactor suffix rendering logic in flux:menu.item component#2630ghabriel25 wants to merge 1 commit into
flux:menu.item component#2630ghabriel25 wants to merge 1 commit into
Conversation
Member
|
@ghabriel25 thanks for the PR! Personally, I prefer the before as I find it easier to read 😅 mainly because I know nothing in that block will happen if there is no suffix. But let's see what Caleb thinks |
Contributor
Author
|
@joshhanley It's okay. This refactor just following how other components handle conditional slot/text |
Collaborator
|
A more compelling argument here would be that the component renders more correctly now. Before, the truthiness check would disregard the suffix if the value is 
|
Contributor
Author
|
@ganyicz Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a tiny refactor for
flux:menu.itemBefore
After
File Changed
stubs/resources/views/flux/menu/item.blade.php