Added support for left-aligned radio cards#2657
Open
joelstein wants to merge 1 commit into
Open
Conversation
Extended the radio "cards" variant's "indicator" prop to accept a position. "start"/"left" render the indicator on the left side of the card, while "end"/"right"/true keep the existing right-aligned default and false continues to hide it. The position can be set per card or on the group (inherited via @AWare).
Contributor
|
Hi @joelstein Have you try this with Blaze enabled? |
Author
|
@ghabriel25 Yes, I tested it with Blaze enabled, and it works correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scenario
Users are accustomed to radio buttons with the indicator on the left. I'd like the ability to easily use this convention.
The problem
The
indicatorprop does not currently supportleftorstart.The solution
I extended the radio
cardsvariant'sindicatorprop to accept a position.start/leftrender the indicator on the left side of the card, whileend/right/truekeep the existing right-aligned default, andfalsecontinues to hide it. The position can be set per card or on the group (inherited via@aware).Fixes #2654.