Fix cursor pagination crash on empty page#2663
Open
joshhanley wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Scenario
When a Flux pagination component renders cursor pagination on an empty page, Flux can throw an error instead of rendering the pagination controls.
This can happen when a stale cursor URL is opened, records are deleted, or filtering leaves the current cursor page empty.
The Problem
Flux's simple pagination view calls
->encode()directly on the previous and next cursor values:Laravel's cursor paginator returns
nullfrompreviousCursor()andnextCursor()when the current page has no items. The pagination buttons can still render in that state because they are controlled byonFirstPage()andhasMorePages().That means Flux can call
encode()onnullwhile rendering the previous or next button.The Solution
Use the same approach that was merged in Livewire in livewire/livewire#10302.
Capture the previous and next cursors before rendering the buttons, then fall back to the current cursor when Laravel returns
null.The
wire:keyandsetPagecalls now use null-safe encoding, so an empty cursor page reloads the current cursor instead of throwing while the view renders.Related to livewire/livewire#10302