Fix field spacing when only using description#2665
Open
joshhanley wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Scenario
When rendering Flux input fields, a description without a label sits directly against the input. The spacing is correct for a label-only field, and also for a field that has both a label and description.
The Problem
The field spacing selector handles
label+descriptionbut not description on it's down. As such the description has no bottom margin when there is no label.The Solution
Add a field spacing selector for descriptions that are the first child and have following content. This gives description-only fields the same
mb-3gap used between label descriptions and controls.'[&>[data-flux-description]:first-child:has(+*)]:mb-3',The selector is scoped to that leading-description case, so existing label + description spacing remains unchanged.
Fixes #2664