Open
Conversation
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v18.1.8
Click here for the full clang-format patch
diff --git a/src/AMSlib/AMSTensor.cpp b/src/AMSlib/AMSTensor.cpp
index 8362f41..45a41e2 100644
--- a/src/AMSlib/AMSTensor.cpp
+++ b/src/AMSlib/AMSTensor.cpp
@@ -36 +36,2 @@ bool AMSTensor::isContiguous(AMSTensor::IntDimType expected_stride) const
-namespace {
+namespace
+{
@@ -53 +54 @@ constexpr AMSDType scalar_to_ams_dtype()
-}
+} // namespace
diff --git a/src/AMSlib/wf/interface.cpp b/src/AMSlib/wf/interface.cpp
index b413f26..07a6611 100644
--- a/src/AMSlib/wf/interface.cpp
+++ b/src/AMSlib/wf/interface.cpp
@@ -105 +105,2 @@ static ams::SmallVector<ams::AMSTensor> torchToAMSTensors(
- throw std::runtime_error("torchToAMSTensors: unsupported tensor scalar type");
+ throw std::runtime_error(
+ "torchToAMSTensors: unsupported tensor scalar type");
Have any feedback or feature suggestions? Share it here.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for
int32_tandint64_tas "scalar" types forAMSTensor.Also fix an unrelated minor bug in eos_ams, where the
densitywas used twice instead of theenergy.