Fix SPINDLE_DEBUG + SPINDLE_TEST in SPANK plugin#146
Open
nchaimov wants to merge 1 commit intollnl:develfrom
Open
Fix SPINDLE_DEBUG + SPINDLE_TEST in SPANK plugin#146nchaimov wants to merge 1 commit intollnl:develfrom
nchaimov wants to merge 1 commit intollnl:develfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the log daemons would not start correctly when Spindle was launched through the SPANK plugin if both
SPINDLE_DEBUGandSPINDLE_TESTwere set.While there is existing code to handle environment forwarding, it did not set environment variables seen by slurmstepd, which is where Spindle is started on the compute nodes. The
TMPDIR,SPINDLE_DEBUG, andSPINDLE_TESTenvironment variables are now read from the srun/local environment and use to set the corresponding variables in theslurm_spank_task_initcallback. This has to happen before any debug messages are logged.