-
Notifications
You must be signed in to change notification settings - Fork 15.5k
[SYCL] SYCL host kernel launch support for the sycl_kernel_entry_point attribute. #152403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tahonermann
wants to merge
19
commits into
llvm:main
Choose a base branch
from
tahonermann:sycl-upstream-fe-sycl_kernel_entry_point-host
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
919cd88
[SYCL] SYCL host kernel launch support for the sycl_kernel_entry_poin…
tahonermann 350a476
Add diagnostics for use of 'this' in a potentially evaluated expression.
tahonermann 1f1b8b7
Remove stale FIXME comment regarding diagnostics for 'this'.
tahonermann 2a1c23d
Add tests for kernel name character encoding concerns.
tahonermann c1ffcf8
[SYCL-Upstreaming] Add support for host kernel launch stmt generation…
Fznamznon 59baed4
[SYCL-Upstreaming] Fix a crash (#52)
Fznamznon 4abaf06
[SYCL-Upstreaming] Fix a crash an argument of skep function is not tr…
Fznamznon 9779525
Correct expected AST output for a test following a rebase.
tahonermann 07c9c1c
Misc cleanup.
tahonermann 5b18f99
Address clang-format complaints.
tahonermann 8a4fc3f
Added support for passing arguments to sycl_kernel_launch as xvalues.
tahonermann 69740b2
Prohibited use of the sycl_kernel_entry_point attribute with a non-st…
tahonermann 1aee751
Diagnostic improvements, additional tests.
tahonermann fa42860
Make clang-format happy again.
tahonermann f89a6af
Reworded much of the sycl_kernel_entry_point attribute documentation.
tahonermann ee8ba91
Added an additional test case to sycl-kernel-launch-ms-compat.cpp.
tahonermann ac92913
Fix a style nit noted in code review.
tahonermann 1035a57
Addressed code review comments from Mariya and corrected a grammar is…
tahonermann 6da9cc9
Added coge generation tests for exception handling.
tahonermann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we remove comments for these setters and getters. They do not seem useful to me as they just repeat the method's names.
The same applies to
UnresolvedSYCLKernelCallStmtclass methods.