[mlir][tosa] Add constant folding for tosa.add_shape operation #173112
+852
−566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the 'simple' folder tests (invoked via `--canonicalize`) away from other layerwise constant folding tests (invoked via `--tosa-layerwise-constant-fold`) into a separate test file to help reduce confusion. Also rename the layerwise folding test file to reflect the the pass name that they are invoked by. Change-Id: I22bfa76480eddd8f850702986d79608d956e766a
For these folders to be TOSA compliant, they need to check for overflow. This commit adds those checks, subsequently preventing folding if an overflow is detected. This commit also fixes the greater/greater_equal folders to account for unsigned types. Change-Id: I2b5a5b92fb840d6c34a1f2faa18ae68a20d0ecdf
This commit introduces constant folding for the tosa.add_shape operation. When both operands of the add_shape operation are constant shapes, the operation is evaluated at compile-time. Change-Id: I5567fae8290bf238f809088573d40666fe3bdf51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces constant folding for the tosa.add_shape operation. When both operands of the add_shape operation are constant shapes, the operation is evaluated at compile-time.
Note: this PR currently contains the contents of other PR's: #172691, #172695