Skip to content

[MC] Handle malformed target-feature #173119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sweiglbosker wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −3
Open

[MC] Handle malformed target-feature #173119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions llvm/lib/MC/MCSubtargetInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,11 @@ void ClearImpliedBits(FeatureBitset &Bits, unsigned Value,

static void ApplyFeatureFlag(FeatureBitset &Bits, StringRef Feature,
ArrayRef<SubtargetFeatureKV> FeatureTable) {
assert(SubtargetFeatures::hasFlag(Feature) &&
"Feature flags should start with '+' or '-'");

if (!SubtargetFeatures::hasFlag(Feature)) {
errs() << "Feature flag '" << Feature
<< "' must start with either '+' or '-' (ignoring feature)\n";
Copy link
Contributor

@nikic nikic Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reportFatalUsageError().

However, it would be even better to check this inside the IR verifier instead.

return;
}
// Find feature in table.
const SubtargetFeatureKV *FeatureEntry =
Find(SubtargetFeatures::StripFlag(Feature), FeatureTable);
Expand Down
9 changes: 9 additions & 0 deletions llvm/test/CodeGen/Generic/invalid-target-feature.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
; Check that we handle a malformed feature flag gracefully.

; RUN: llc %s -o - 2>&1 | FileCheck %s

; CHECK: Feature flag 'foobar' must start with either '+' or '-' (ignoring feature)
define void @f() "target-features"="foobar" {
entry:
ret void
}