You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Quick review takeaway: good direction, but I would not merge until the migration/address-ownership questions are closed.
Critical / high-risk items to verify:
Existing bridgeEthereumAddress values can bypass new IBEX receive-info creation. Can we prove every existing address is tied to the correct ETH-USDT IBEX wallet, or do we need a migration/backfill?
ensureEthUsdtCashWallet(account) runs before the existing-VA idempotency guard. Is it intentional to promote the USDT wallet to default even when a Bridge VA already exists?
Ibex.getAccountDetails(walletId, currency) converts balances based on caller-provided currency. Are all callsites audited so we do not create wrong-unit balance reads?
Webhook now accepts USDT + ethereum and rejects Tron. Confirm upstream payloads and existing customer deposit instructions are fully cut over.
Withdrawal idempotency is improved, but concurrent retries still need DB-level uniqueness/transactional protection against duplicate pending rows.
PR body says tests/build passed, but GitHub shows Checks (0), so CI/build evidence should be attached or run before merge.
Note: I could not enable GitHub Pages on lnflash/flash from this account; repository settings show no Pages/options access. The rendered link above uses the uploaded GitHub branch file via htmlpreview as an interim full-artifact view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements ETH-USDT Cash Wallet provisioning during Bridge virtual account creation.
Changes:
Tests: 14/14 passed (bridge + wallet), yarn build clean