Open
Conversation
xresende
changed the title
xresende
requested review from
JeffersonBarrosVieira,
VitorSouzaLNLS,
fernandohds564 and
vellosok75
fernandohds564
approved these changes
Mar 26, 2026
vellosok75
approved these changes
Mar 26, 2026
JeffersonBarrosVieira
approved these changes
Mar 26, 2026
VitorSouzaLNLS
approved these changes
Mar 27, 2026
| self._brho, self._velocity, self._beta, self._gamma, \ | ||
| self.trackcpp_acc.energy = \ | ||
| _mp.beam_optics.beam_rigidity(gamma=1.0) | ||
| electron_rest_energy_ev = _c.electron_rest_energy * _u.joule_2_eV |
Contributor
There was a problem hiding this comment.
electron_rest_energy_ev → electron_rest_energy_eV
Contributor
Author
There was a problem hiding this comment.
I originally used _eV, @VitorSouzaLNLS , but my ruff linter complained about it and I gave up. do you a strong opinion/reason about this choice ?
Contributor
There was a problem hiding this comment.
I prefer how it is now.
Contributor
There was a problem hiding this comment.
I originally used _eV, @VitorSouzaLNLS , but my ruff linter complained about it and I gave up. do you a strong opinion/reason about this choice ?
No, not at all. I just added this comment because of the mismatch between the units in mathphys and this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.