Skip to content

BUGFIX: Operations on "time aware" vectors were being performed even if they were empty. #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VitorSouzaLNLS wants to merge 2 commits into
base: master
Choose a base branch
from
Open

BUGFIX: Operations on "time aware" vectors were being performed even if they were empty. #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
420ace0
BUGFIX: operate on time_aware vectors only if they are not empty
VitorSouzaLNLS Mar 27, 2026
a99ef49
MNT: reorder code ("if" condition on "update_time_aware_info"
VitorSouzaLNLS Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/accelerator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,10 @@ void Accelerator::update_time_aware_info(void) const {
}
}

if (this->time_aware_indices.size() > 0) {
time_aware_displacements[0] += s_pos;
}
if (this->time_aware_indices.size() == 0) return;

time_aware_displacements[0] += s_pos;

//? NOTE : The diference between "line_length" and the sum of "time_aware_displacements" (cum_length) is on the order of
//? 1e-15 ~ 1e-16. The propagation of this tiny error affects the tracking. The following lines avoid losing precision.
double cum_length = std::accumulate(time_aware_displacements.begin(), time_aware_displacements.end(), 0.0);
Expand Down
Loading