Update RF devices on machine shutdown script#169
Open
murilobalves wants to merge 3 commits intomasterfrom
Open
Update RF devices on machine shutdown script#169murilobalves wants to merge 3 commits intomasterfrom
murilobalves wants to merge 3 commits intomasterfrom
Conversation
anacso17
reviewed
Oct 21, 2024
Comment on lines
+533
to
+534
| for cavmon in cavmons: | ||
| if not self._wait_devices_propty( |
Contributor
There was a problem hiding this comment.
Hi @murilobalves , in this case it seems we don't need the loop here.
Contributor
There was a problem hiding this comment.
what about this point, @anacso17? Since Murilo is not here anymore, could you fix this?
fernandohds564
approved these changes
Jul 25, 2025
JeffersonBarrosVieira
approved these changes
Jul 28, 2025
JeffersonBarrosVieira
left a comment
JeffersonBarrosVieira
left a comment
There was a problem hiding this comment.
I made the updates by removing the IDs that are not installed and including the new IDs. I also noticed that we forgot to add the Carnauba APU device to the dev-packages repository, so I made a PR there as well.
devices['apu22_17SA'] = IDParking(
_ID.DEVICES.APU.APU22_17SA, log_callback=self._log_callback
) # SPUThis call would be broken.
fernandohds564
approved these changes
Jul 30, 2025
xresende
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: