Fix for #124: Date field in composite

[ekes]

The suggestion from #124 overriding the preValidateDate to make workaround from parent to put datetime object into the form state input.

[MattOz-CDS]

Thanks :)

[sgroi-l]

Works for me. Thanks Ekes

[finnlewis]

Thanks for this @ekes ! And thanks for approving @sgroi-l @MattOz-CDS .

I'm not totally sure how to test this.

By 'composite' do we mean using this project? https://www.drupal.org/project/webform_composite

I'd like to be able to reproduce the error and see it go away with this change.

[msayoung]

@finnlewis - that's correct. that module allows you to create a resuable composite like an About you composite, which you can then drop in to any of your forms.

Create them here: admin/structure/webform/config/composite

It then gives the validation error @ekes mentioned in #124

I'm testing this too now.

[msayoung]

works for me

[finnlewis]

I see!

Confirmed that a LocalGov Forms Date field in a Webform Composite thing does not validate the date when submitting the form.

Checking out this branch and the LocalGov Forms Date field does validate.

:)

[finnlewis]

I'd say that's a good number of approvals!

Thanks folks :)

[finnlewis]

Discussing at Merge Tuesday.

In the move to drupal.org, we've tagged a new release on Drupal.org for https://www.drupal.org/project/localgov_forms/releases/1.1.0-beta11

So:

1. we will not merge this here
2. we will push this branch to drupal.org
3. create the merge request again on drupal.org
4. release on drupal.org

We want to avoid any further merges / releases on github if we can.

[finnlewis]

Merge request on drupal.org https://git.drupalcode.org/project/localgov_forms/-/merge_requests/2

[finnlewis]

This has been merged on druapl.org https://git.drupalcode.org/project/localgov_forms/-/merge_requests/2

Closing here.