Fix rds.toJsonObject method only supporting string values#122
Merged
Conversation
Currently, the `toJsonObject` method from `rds` only supports `{ stringValue: string }`, but other value types can appear in payloads, such as `{ longValue: int }`.
This PR changes it so it assumes value types of any kind, as long as the value type is an object with a key and the value we want to map.
skyrpex
force-pushed
the
fix-rds.toJsonObject
branch
from
7b72488 to
e2141a3
Compare
Contributor
Author
|
There are more data type which we don't still handle: see https://docs.aws.amazon.com/rdsdataservice/latest/APIReference/API_Field.html. I'll add support for those types as well. |
simonrw
approved these changes
Jun 4, 2025
Collaborator
simonrw
left a comment
simonrw
left a comment
There was a problem hiding this comment.
Thanks for adding this funtionality!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
toJsonObjectmethod fromrdsonly supports{ stringValue: string }, but other value types can appear in payloads, such as{ longValue: number },{ doubleValue: number }, etc. See https://docs.aws.amazon.com/rdsdataservice/latest/APIReference/API_Field.html for more information.This PR changes
toJsonObjectso it extracts the values properly. It also uses the row label if available, and the row name as a fallback.