Conversation
Member
Author
thrau
force-pushed
the
tag-based-releases
branch
from
55ee7e4 to
303ae5f
Compare
bentsku
approved these changes
Apr 2, 2026
Collaborator
bentsku
left a comment
bentsku
left a comment
There was a problem hiding this comment.
LGTM! Just a few questions but nothing blocking, great to see this! No more tokens and much easier to deploy and less easy to mess up!
| $(VENV_ACTIVATE): pyproject.toml | ||
| test -d .venv || $(VENV_BIN) .venv | ||
| $(VENV_RUN); pip install --upgrade pip setuptools wheel | ||
| $(VENV_RUN); pip install --upgrade pip |
Collaborator
There was a problem hiding this comment.
quick question: were were publishing wheels before? and would we stop? feels like we were not
Member
Author
There was a problem hiding this comment.
we were indeed publishing wheels (example: https://pypi.org/project/rolo/#rolo-0.8.1-py3-none-any.whl)
we are still publishing them, but now they are built by hatchling, so setuptools and wheel are no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We've been migrating to hatch-vcs and tag-based releasing for our OSS libraries.
Following our user guide for tag-based pypi releases, I made all the necessary changes. I already configured GitHub and PyPI accordingly.
Changes
vM.m.pand pushing it