Skip to content

Remove mention of port 19999 from documentation#250

Merged
bryans99 merged 4 commits into
masterfrom
bnr/remove-19999
Apr 13, 2026
Merged

Remove mention of port 19999 from documentation#250
bryans99 merged 4 commits into
masterfrom
bnr/remove-19999

Conversation

@bryans99
Copy link
Copy Markdown
Collaborator

No description provided.

@bryans99 bryans99 requested a review from a team as a code owner April 13, 2026 16:51
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Looker API and host configurations by removing default port numbers across configuration files and documentation, alongside a version bump to 2.0.8. Review feedback identifies a typo in the demo/looker.ini file and suggests providing non-empty default fallbacks for API URLs and hosts in config.js and server/config.ts to prevent potential runtime failures when environment variables are absent.

Comment thread demo/looker.ini Outdated
Comment thread config.js Outdated
Comment thread server/config.ts Outdated
Comment thread server/config.ts Outdated
@josephaxisa josephaxisa self-requested a review April 13, 2026 18:49
@bryans99 bryans99 merged commit 8f98b87 into master Apr 13, 2026
8 checks passed
@bryans99 bryans99 deleted the bnr/remove-19999 branch April 13, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants