Skip to content

Fix missing error handling in OmniSensor.fetch_state() #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StevenEmelander wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix missing error handling in OmniSensor.fetch_state() #357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/aiovantage/_objects/omni_sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@

from typing_extensions import override

from aiovantage import logger
from aiovantage.command_client import Converter
from aiovantage.errors import CommandError, ConversionError
from aiovantage.object_interfaces import SensorInterface

from .sensor import Sensor
Expand Down Expand Up @@ -110,7 +112,15 @@ async def set_level(self, level: Decimal, *, sw: bool = False) -> None:

@override
async def fetch_state(self) -> list[str]:
return self.update_properties({"level": await self.get_level(hw=True)})
# This override bypasses Interface.fetch_state(), which catches
# errors per property. Apply the same error handling here.
try:
level = await self.get_level(hw=True)
except (CommandError, ConversionError) as ex:
logger.warning("Failed to fetch OmniSensor level: %s", ex)
return []

return self.update_properties({"level": level})

@override
def handle_object_status(self, method: str, result: str, *args: str) -> list[str]:
Expand Down