chore: update generated files from PR #11292#33
Conversation
![loyaltylion-minerva[bot]](https://avatars.githubusercontent.com/in/3258495?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto-generated codegen PR from hogwarts #11292. The regenerated TypeScript reflects three additive contract changes:
- New
loyalty_pass_installrule kind —RuleLoyaltyPassInstallandCustomerAvailableRuleLoyaltyPassInstallinterfaces added with the same shape as sibling rule kinds (limit/kind/variants and limit/kind/variant/context respectively), inserted into theSiteConfiguration.rulesandCustomerEnrolled.available_rulesunions, and added to thekindliteral enums onCustomerHistoryActionEarnedPointsFromRule.ruleandCustomerHistoryActionReceivedReward.rule. - New optional
country?: stringquery parameter, added uniformly to all 21 GET operations that already acceptlanguage?: unknown— consistent coverage, no missed endpoints. - New
title: stringfield onCustomerHistoryActionReceivedReward.rule.
All changes are additive and look like faithful regeneration — no manual edits or drift from the codegen pattern visible. Build/typecheck wasn't run as this PR only touches generated .d.ts-style types and runs through tsc at downstream consumer build time; downstream packages will pick this up as new optional fields/union variants without breakage.
One asymmetry worth confirming against the source PR before merging — see line comment on CustomerHistoryActionEarnedPointsFromRule.rule.
| id: number; | ||
| /** @enum {string} */ | ||
| kind: "birthday" | "collection_purchase" | "newsletter_signup" | "pageview" | "product_purchase" | "purchase" | "join_program" | "review" | "custom" | "facebook_like" | "twitter_follow" | "instagram_follow" | "instagram_mention" | "instagram_post_hashtag" | "tiktok_follow" | "tiktok_post_hashtag" | "referral" | "clickthrough" | "retail_purchase"; | ||
| kind: "birthday" | "loyalty_pass_install" | "collection_purchase" | "newsletter_signup" | "pageview" | "product_purchase" | "purchase" | "join_program" | "review" | "custom" | "facebook_like" | "twitter_follow" | "instagram_follow" | "instagram_mention" | "instagram_post_hashtag" | "tiktok_follow" | "tiktok_post_hashtag" | "referral" | "clickthrough" | "retail_purchase"; |
There was a problem hiding this comment.
The rule reference here (in CustomerHistoryActionEarnedPointsFromRule) still only carries id + kind, while the symmetrical rule reference on CustomerHistoryActionReceivedReward (line 4740) gained a new title: string field in this same regeneration. The two rule-reference subobjects had identical shapes before this PR, and the new title would be just as useful on the "earned points from rule" surface as on "received reward" — e.g. "Refer a friend — 500 points" alongside the existing reward-side example. Worth confirming with the source PR (#11292) author whether this asymmetry is deliberate (the field description mentions surfacing "alongside the reward", which hints at intent) or an oversight on the earned-points action. If it's an oversight, a follow-up to the source contract would close the gap; nothing to fix here in the codegen output itself.
1 participant
Auto-generated by the CI pipeline.
Source: https://github.com/loyaltylion/hogwarts/pull/11292
These files were regenerated from changes to the API contracts. Review and merge alongside the main PR.
Generated files:
src/types/api.tssrc/types/schemas.ts