Skip to content

chore: update generated files from PR #11478#37

Open
loyaltylion-bot wants to merge 1 commit into
mainfrom
codegen/pr-11478
Open

chore: update generated files from PR #11478#37
loyaltylion-bot wants to merge 1 commit into
mainfrom
codegen/pr-11478

Conversation

@loyaltylion-bot

Copy link
Copy Markdown
Collaborator

Auto-generated by the CI pipeline.

Source: https://github.com/loyaltylion/hogwarts/pull/11478

These files were regenerated from changes to the API contracts. Review and merge alongside the main PR.

Generated files:

  • src/types/api.ts
  • src/types/schemas.ts

@loyaltylion-minerva loyaltylion-minerva Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static review only, per the environment constraints. I found one client-surface gap: the generated types now expose country-aware API requests, but the package's exported convenience client does not appear to provide any way to send the new country query parameter, so callers using createHeadlessApiClient will still always get site-default country filtering.

Comment thread src/types/api.ts
language?: unknown;
language?: string;
/** @description ISO 3166-1 alpha-2 country code for the customer. Used to filter rewards by country availability. If not provided, the site default is used */
country?: string;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new query parameter is not reachable through the exported convenience client. Every method in src/client.ts currently builds params with only path, and HeadlessApiClientOptions has channel/language but no country, so consumers using createHeadlessApiClient cannot request country-specific reward availability even though the generated API types now support it. Please thread this through the wrapper, either as a client-level option or as per-call query params, before publishing these generated types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant