Skip to content

chore: update generated files from PR #11454#40

Open
loyaltylion-bot wants to merge 1 commit into
mainfrom
codegen/pr-11454
Open

chore: update generated files from PR #11454#40
loyaltylion-bot wants to merge 1 commit into
mainfrom
codegen/pr-11454

Conversation

@loyaltylion-bot

Copy link
Copy Markdown
Collaborator

Auto-generated by the CI pipeline.

Source: https://github.com/loyaltylion/hogwarts/pull/11454

These files were regenerated from changes to the API contracts. Review and merge alongside the main PR.

Generated files:

  • src/types/api.ts
  • src/types/schemas.ts

@loyaltylion-minerva loyaltylion-minerva Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one integration issue: the generated OpenAPI types now expose a country query parameter for country-based reward filtering, but the exported createHeadlessApiClient wrapper still has no country option and does not pass query params on its requests. Consumers using the documented client will therefore continue to get site-default country filtering even after this generated type update.

Reviewed statically only, per the environment constraints; I did not run package managers, typecheck, lint, build, or tests.

Comment thread src/types/api.ts
language?: unknown;
language?: string;
/** @description ISO 3166-1 alpha-2 country code for the customer. Used to filter rewards by country availability. If not provided, the site default is used */
country?: string;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new country parameter is exposed in the raw OpenAPI operation types, but the package's public convenience client does not have any way to send it. createHeadlessApiClient only accepts channel and language at construction time, sends those as headers, and each wrapper method only passes params.path, so calls like configuration.getConfiguration, customers.initializeSession, and reward redemptions will still omit country and get the site-default reward availability. Can we add a matching country?: string option, or per-call parameter if the country can vary by customer/session, and include it in the wrapper requests wherever these generated operations accept it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant