Skip to content

chore: update generated files from PR #11547#47

Open
loyaltylion-bot wants to merge 1 commit into
mainfrom
codegen/pr-11547
Open

chore: update generated files from PR #11547#47
loyaltylion-bot wants to merge 1 commit into
mainfrom
codegen/pr-11547

Conversation

@loyaltylion-bot

Copy link
Copy Markdown
Collaborator

Auto-generated by the CI pipeline.

Source: https://github.com/loyaltylion/hogwarts/pull/11547

These files were regenerated from changes to the API contracts. Review and merge alongside the main PR.

Generated files:

  • src/types/api.ts
  • src/types/schemas.ts

@loyaltylion-minerva loyaltylion-minerva Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No line-specific elegance findings. This is a generated-only PR from the upstream API contract change, and the new surface is coherent across api.ts and schemas.ts: the enroll operation has matching response/error schemas, language is consistently tightened to string, and the new loyalty_pass_install rule kind is threaded through site configuration, customer available rules, and history rule-kind unions.

One scope note: the hand-written convenience client still does not expose every generated OpenAPI path, including this new enroll endpoint, but that wrapper is outside this PR diff and there is already a pre-existing generated path without a wrapper (rewards/custom/redeem). If the intent is for this generated PR to ship only the type surface, this looks consistent.

Comment thread src/types/api.ts
@@ -63,6 +63,22 @@ export interface paths {
patch?: never;
trace?: never;
};
"/headless/2025-06/{site_id}/customers/{merchant_id}/enroll": {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Respond to this comment to discuss this review with me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant