Namespace listener names by port#2
Merged
Merged
Conversation
start_listeners/2 named acceptor processes purely by their iteration index (whitecap_listener_<N>), so two calls on the same node collided as soon as the second countdown reached an N already used by the first. A typical setup of one metrics listener on 9091 plus sixteen on the main port crashed on whitecap_listener_1. Including the configured port in the registered name makes multiple start_listeners calls on different ports independent. Same port + same N still collides, which is the only case that should: rerunning start_listeners against an already-started port is a real error. Bump to 0.1.2 and add an e2e regression test that starts a second listener group on a different port.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.