No more jquery 1#135
Merged
Merged
Conversation
Stop using jquery in our own html pages. This uses css animation instead of jquery transitions, and uses vanilla js instead of jquery for finding elements.
Use raw js instead. Also refactor the html a little bit to make it easier to manipulate components.
At some point the autocomplete functionality broke. This restores it. It also removes some more jquery code, and uses the built-in browser completion.
Contributor
Author
|
You may want to review commit-by-commit. |
This upgrades bootstrap and removes the rest of the jquery code, and finally removes the vendored jquery dependency itself. This has some minor changes to the appearance of the interface, but the functionality should be the same.
tmccombs
force-pushed
the
no-more-jquery-1
branch
from
f87a533 to
0c82f41
Compare
jjudd
approved these changes
Jun 3, 2026
Contributor
jjudd
left a comment
jjudd
left a comment
There was a problem hiding this comment.
LGTM. I had a few comments I think we should address before merging.
use let and const instead of var in jobs.scala.html
Add lisense comment for bootstrap icons. I'm not sure if it qualifies as a "substantial portion" or not, but we'll include it just in case.
This div is no longer necessary, and was missing the end tag. I'm not sure how it got left.
Make sure that we only update the job-names-list if it exists.
jjudd
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes jQuery as a dependency of the piezo admin. It also does some other yaks I shaved along the way:
The bootstrap upgrade changed the appearance a little bit, but the functionality should be the same.