Reuse memoizeAsyncWithTtl for the codex metadata scan#171
Merged
Conversation
The codex `~/.codex/sessions` metadata scan (bounded in #169) carried its own inline TTL cache with identical semantics to the `memoizeAsyncWithTtl` helper added for the Hermes scan dedup (#170): share one in-flight promise per TTL window, never cache rejections. Fold the codex cache into the shared helper to remove the duplicated cache bookkeeping. No behavior change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
luckeyfaraday
changed the base branch from
fix/hermes-session-scan-dedup
to
main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fold the inline codex metadata TTL cache into the shared
memoizeAsyncWithTtlhelper.#169 bounded the workspace-independent
~/.codex/sessionsmetadata scan with a hand-rolled 30s cache. #170 then addedmemoizeAsyncWithTtl(client/electron/ttl-cache.ts) for the Hermes scan dedup — with identical semantics: share one in-flight promise per TTL window, never cache rejections. This PR removes the duplicated bookkeeping by reusing the helper for the codex scan too.Change
codexMetadataCachevariable and thecachedCodexJsonlMetadata()function body.const cachedCodexJsonlMetadata = memoizeAsyncWithTtl(CACHE_TTL_MS, scanCodexJsonlMetadata).scanCodexJsonlMetadatais a hoisted function declaration andmemoizeAsyncWithTtldefers invocation to first call, so there is no TDZ concern. No behavior change.Stacking
Based on
fix/hermes-session-scan-dedup(#170), since the helper lands there. Retarget tomainonce #170 merges.Verification
npm run build:electron— cleannpm run test:electron— 138/138 pass🤖 Generated with Claude Code