Supporting different javascript runtime options. npm, yarn, and bun.#1970
Closed
russ wants to merge 1 commit intoluckyframework:mainfrom
Closed
Supporting different javascript runtime options. npm, yarn, and bun.#1970russ wants to merge 1 commit intoluckyframework:mainfrom
russ wants to merge 1 commit intoluckyframework:mainfrom
Conversation
This is in tandem with luckyframework/lucky_cli#889 I'm not a huge fan of how this part has to be done. I would love a different approach.
Member
|
So the main question here is, if we just got rid of the browser-sync (which may not even be working, and have been broken for some time), then none of this becomes required. The swap out becomes a lot easier to handle. We wouldn't lose the auto-reload on the Crystal side because that's still handled by the websocket reloader which is default anyway. Though, I'm not sure if any of the javascript or css files are watched and reloaded on change with that... |
Contributor
Author
|
So I think was covered in #1982 ? Much better I might add. |
Member
|
Yeah, I think this PR was only needed to work around browser-sync, but since we're basically ripping that out, then none of this should be needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Supporting different javascript runtime options. npm, yarn, and bun.
This is in tandem with luckyframework/lucky_cli#889
Description
I'm not a huge fan of how this is done. I would love to see a different approach.
Checklist
crystal tool format spec src./script/setup./script/test