Draft
Conversation
This fixes the Smash ball logo on the app icon and removes the icon masks (the rounded corners) as they are no longer needed. It also simplifies the filenames of the icons. For anyone who needs to make changes or export additional icons, my vector recreation is included too (I used Inkscape). Fingers crossed my changes to Contents.json do not break backward compatibility with older versions of Xcode. And normally the author is supposed to be the bundle ID but it seems to work fine so what the heck, might as well save a few bytes.
Contributor
Author
|
Converting to draft as I noticed the Smash ball is just barely larger than the download progress circle and I might as well make it fit. We can also remove the smaller icon sizes and let iOS do the work, and iOS 18 added customizing icons to be dark or tinted, so those variants should be included as well. |
This tweaks the icon colors, fixes icons that were previously left unfixed due to their masks (I believe these ones are used for the Debian package), shrinks the Smash ball so it fits neatly inside the iOS download circle, minifies the SVG even further, removes unnecessary icon sizes and adds dark and tinted icons for iOS 18 users. The icon mask uses a radius of 1.25, which seems to be correct for iOS 8 and up (older radii are untested and out of scope). You can add this in Inkscape by selecting the yellow rectangle, then selecting the rectangles and squares tool (R key) and changing the horizontal radius (Rx) and vertical radius (Ry) in the toolbar. The tinted icon uses the grayscale filter in Inkscape with the following settings: - Red: 0.24 - Green: 0.84 - Blue: 0.07 - Lightness: 0.16
Contributor
Author
|
I have left this as a draft for a while because I wanted to add it to other platforms (primarily Windows, which has no icon at all). The previous commit accomplished everything I wanted for iOS though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the Smash ball logo on the app icon and removes its mask (mostly because I was too lazy to add it, but it was only required in vintage iOS versions anyway).
I also included my vector recreation so others can change and export the icon as needed.