Skip to content

Fix Cloudflare preview workflow for fork PRs#1378

Open
LUKSOAgent wants to merge 1 commit into
lukso-network:mainfrom
LUKSOAgent:fix/cloudflare-fork-pr-preview
Open

Fix Cloudflare preview workflow for fork PRs#1378
LUKSOAgent wants to merge 1 commit into
lukso-network:mainfrom
LUKSOAgent:fix/cloudflare-fork-pr-preview

Conversation

@LUKSOAgent

Copy link
Copy Markdown
Contributor

Summary

  • skip the automatic Cloudflare deploy job for fork PRs, where repository secrets are intentionally unavailable
  • make Wrangler deploy failures fail the job instead of being hidden by tee
  • add a maintainer-triggered Cloudflare preview workflow for fork PRs that builds PR code without secrets, uploads the static artifact, then deploys only that artifact with Cloudflare secrets

Verification

  • npx --yes prettier@3.8.1 --check .github/workflows/ci.yml .github/workflows/cloudflare-pr-preview.yml
  • git diff --check -- .github/workflows/ci.yml .github/workflows/cloudflare-pr-preview.yml
  • actionlint .github/workflows/ci.yml .github/workflows/cloudflare-pr-preview.yml
  • npx --yes wrangler@4.7.1 --version

Notes

After this is merged, maintainers can run cloudflare-pr-preview manually for fork PRs such as #1377 to publish https://pr-1377.tech-docs-2ac.pages.dev without exposing Cloudflare secrets to fork code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant