This repository was archived by the owner on Sep 22, 2022. It is now read-only.
My App#4
Open
ankormoreankor wants to merge 2 commits into
Open
Conversation
added 2 commits
December 18, 2018 00:24
lumejiodev
reviewed
Dec 25, 2018
| .main { | ||
| display: flex; | ||
|
|
||
| padding-top: 54px; |
| padding-right: 75px; | ||
| width: 100%; | ||
|
|
||
| &-block { |
Owner
There was a problem hiding this comment.
хороший подход, но обычно лучше делать отдельно (.main и .main-block). Меньше ёлки в коде, и чуть лучше читаемость, при этом по логике это тоже норм
| &_white { | ||
| background-color: $white; | ||
| } | ||
| &_gl { |
Owner
There was a problem hiding this comment.
нехорошее сокращение. Неочевидно из названия что это
| @@ -0,0 +1,17 @@ | |||
| .icons { | |||
| &__list { | |||
| display: flex; | |||
| render() { | ||
| return ( | ||
| <main className="App bg_gl"> | ||
|
|
Owner
|
Названия файлов для компонентов делай КемелКейсом. Разделяй UI-элементы от остальных компонентов. Обычно создаётся папка В остальном всё хорошо, но вероятно будут ещё правки когда доверстаешь до конца |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Сделал не всё - не успел, но, думаю, обратная связь не будет лишней