Skip to content

[Quality] Clarify doctor cache wording#239

Merged
luoyuctl merged 1 commit into
masterfrom
quality/238-doctor-cache-wording
May 19, 2026
Merged

[Quality] Clarify doctor cache wording#239
luoyuctl merged 1 commit into
masterfrom
quality/238-doctor-cache-wording

Conversation

@luoyuctl
Copy link
Copy Markdown
Owner

Closes #238

Scope

  • Clarify agenttrace --doctor cache summary wording so parsed session cache entries, reusable current-scan entries, and cached directory listings are distinct.
  • Clarify the cold parsed-session-cache recommendation while noting cached directory listings may still speed discovery.
  • Add focused doctor text coverage for the wording.

Test plan

  • go test ./...
  • go build -o /tmp/agenttrace-quality-238 ./cmd/agenttrace

Risk

Low: diagnostics wording and focused test coverage only.

@luoyuctl luoyuctl added lane/quality Reliability, tests, and diagnostics status/ready-for-review Ready for review labels May 19, 2026
@luoyuctl
Copy link
Copy Markdown
Owner Author

Quality Gatekeeper Review: PASS

Reviewed PR head ce61b510374c4e9b63b03bf7d1ead6585b63e51a in a temporary worktree.

Validation run:

  • go test ./...
  • go build -o /tmp/agenttrace-review-pr-239 ./cmd/agenttrace
  • /tmp/agenttrace-review-pr-239 --doctor
  • /tmp/agenttrace-review-pr-239 --demo --overview -f json

Notes:

  • Doctor output now distinguishes parsed session cache entries, reusable current-scan entries, and cached directory listings.
  • Cold-cache recommendation keeps existing discovery/source information and notes that directory listing cache may still speed discovery.

@luoyuctl luoyuctl merged commit cd45505 into master May 19, 2026
1 check passed
@luoyuctl luoyuctl deleted the quality/238-doctor-cache-wording branch May 19, 2026 21:42
@luoyuctl
Copy link
Copy Markdown
Owner Author

Quality Gatekeeper Review

Verdict: PASS
Risk: Low
Lane: quality
Checks:

  • One logical change
  • Scope is clear
  • Protected files unchanged
  • No secret/session/prompt leakage
  • No public platform-attention target wording
  • go test ./... passed
  • go build passed
  • doctor/demo overview passed
  • Docs/tests updated if needed
    Notes: Reviewed PR [Quality] Clarify doctor cache wording #239 from head ce61b510374c4e9b63b03bf7d1ead6585b63e51a. GitHub mergeStateStatus=CLEAN; CI Test and build succeeded. Changed files are limited to cmd/agenttrace/doctor_test.go and internal/i18n/i18n.go, with focused diagnostic wording and test coverage for parsed session cache entries, current-scan reuse, and cached directory listings.

Validation commands:

  • go test ./...
  • go build -o /tmp/agenttrace-review-pr-239 ./cmd/agenttrace
  • /tmp/agenttrace-review-pr-239 --doctor || true
  • /tmp/agenttrace-review-pr-239 --demo --overview -f json
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-239 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-239-ci scripts/ci/check-output-contract.sh
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-239 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-239-ci scripts/ci/check-deterministic-output.sh
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-239 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-239-ci scripts/ci/check-docs-commands.sh
  • AGENTTRACE_BIN=/tmp/agenttrace-review-pr-239 AGENTTRACE_CI_OUT=/tmp/agenttrace-review-pr-239-ci scripts/ci/check-report-semantics.sh

Decision: Low-risk diagnostics wording/test change is ready to squash merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lane/quality Reliability, tests, and diagnostics status/auto-merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify doctor cache cold and reusable directory wording

1 participant