Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

Let’s demonstrate that Node.js 16 pass the tests#6

Open
cclauss wants to merge 17 commits intolwahonen:mainfrom
cclauss:patch-1
Open

Let’s demonstrate that Node.js 16 pass the tests#6
cclauss wants to merge 17 commits intolwahonen:mainfrom
cclauss:patch-1

Conversation

@cclauss
Copy link
Copy Markdown
Contributor

@cclauss cclauss commented Mar 29, 2024

Please Squash and merge to consolidate all the commits.

Recommendations:

  • Do not run npm test
  • macOS and Ubuntu: Node.js v20.x and Python 3.12
  • Windows: Node.js v16.x and Python 3.11 -- Do not run node-gyp rebuild

Lessons learned:

  1. Node.js >= v21 fails
  2. Node.js >= 18 fails on Windows
  3. Python >= 3.12 fails on Node.js 16 because of distlib fixed in node-gyp v10.0
  4. npm test fails with: npm ERR! Missing script: "test"
  5. node-gyp rebuild fails on Node.js 16

@cclauss cclauss changed the title Let’s demonstrate that Node.js v16.x passes the tests Let’s demonstrate that Node.js 14 and 16 pass the tests Mar 29, 2024
@cclauss cclauss marked this pull request as draft March 29, 2024 04:29
@cclauss cclauss changed the title Let’s demonstrate that Node.js 14 and 16 pass the tests Let’s demonstrate that Node.js 16 pass the tests Mar 29, 2024
@cclauss cclauss marked this pull request as ready for review March 29, 2024 07:40
@Kreijstal
Copy link
Copy Markdown

why this has not been merged, also unmantained? 😂

@cclauss
Copy link
Copy Markdown
Contributor Author

cclauss commented Oct 29, 2024

Please look at node-ffi-napi/node-ffi-napi#269 as mentioned above for workarounds.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants