Support start slide on setup#61
Open
axelson wants to merge 2 commits intolyfeyaj:masterfrom
Open
Conversation
This allows you to add slides dynamically, even when moving backward.
To add a slide that occurs right before the current first slide write
code like the following:
var mySwipe = new Swipe(document.getElementById('slider'), {})
$('.swipe-wrap').prepend('<div>New Slide</div>');
mySwipe.setup({startSlide: 1});
This fork can be installed via bower with: bower install "swipe-js=https://github.com/axelson/swipe.git#2.2.4"
Closed
Author
|
Any thoughts on this? Would be nice to support reinitializing (better performance then a complete kill and new instance I think) for dynamic content. |
Author
|
Any chance on getting this merged? I can fix the conflicts if so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows you to add slides dynamically, even when moving backward.
To add a slide that occurs right before the current first slide write
code like the following:
var mySwipe = new Swipe(document.getElementById('slider'), {})
$('.swipe-wrap').prepend('
mySwipe.setup({startSlide: 1});
This fork can be installed via bower with: bower install "swipe-js=https://github.com/axelson/swipe.git#2.2.4"
Fixes #28
If you'd like I could add some docs as well.