Skip to content
This repository was archived by the owner on Oct 22, 2025. It is now read-only.

add resolve option for custom modal#138

Open
cgoessen wants to merge 3 commits intom-e-conroy:masterfrom
cgoessen:master
Open

add resolve option for custom modal#138
cgoessen wants to merge 3 commits intom-e-conroy:masterfrom
cgoessen:master

Conversation

@cgoessen
Copy link
Copy Markdown

I've added 'resolve' as the last param and kept data for legacy support.
My use case is to use the same controller for full page and modal, which requires to have a few promises resolved in both.

  • remove as not needed after a modalInstance dismiss

@niemyjski
Copy link
Copy Markdown
Collaborator

@cgoessen Can you please resolve the merge conflicts.
@m-e-conroy can you take a look at this.

@cgoessen
Copy link
Copy Markdown
Author

hi,
I rebased my branch from the new upstream but I can't test it at the moment:
https://github.com/cgoessen/angular-dialog-service/tree/rebase-upstream

I'll update my pull request when I know it works.

@niemyjski
Copy link
Copy Markdown
Collaborator

Thank you

@niemyjski
Copy link
Copy Markdown
Collaborator

Looks like there still are some conflicts

@niemyjski
Copy link
Copy Markdown
Collaborator

Can you please resolve any conflicts so we can review and get this merged in.

@cgoessen
Copy link
Copy Markdown
Author

I'll see what I can do.

I don't have the project on which I was working on at that time.

@niemyjski
Copy link
Copy Markdown
Collaborator

Guess we can close this then or merge it in if the conflicts are resolved? Sorry about that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants