Skip to content

fix: skip notification when community has no admin #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xenacode-art wants to merge 10 commits into
base: test
Choose a base branch
from
Open

fix: skip notification when community has no admin #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cf78f37
Merge pull request #112 from m2b3/test
armanalam03 Dec 14, 2025
9be5a37
Sync Alphatest with Test
armanalam03 Mar 8, 2026
30dfccd
Sync Main with AlphaTest
armanalam03 Mar 8, 2026
749292b
Sync test with alphatest
armanalam03 Mar 8, 2026
0f5f039
Sync main with Alphatest
armanalam03 Mar 8, 2026
0952601
Sync AlphaTest with Test
armanalam03 Mar 9, 2026
bd92f99
Sync Main with Alphatest
armanalam03 Mar 9, 2026
009905c
change MAX_COMMUNITIES_PER_USER to 40
armanalam03 Mar 11, 2026
3b28f92
change MAX_COMMUNITIES_PER_USER to 40
armanalam03 Mar 11, 2026
9ca284b
fix: skip notification when community has no admin
xenacode-art Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions articles/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,18 +159,20 @@ def create_article(

# Send notification to the community admin
try:
Notification.objects.create(
user=community.admins.first(),
community=community,
category="communities",
notification_type="article_submitted",
message=(
f"New article submitted in {community.name}"
f" by {request.auth.username}"
),
link=f"/community/{community.name}/submissions",
content=article.title,
)
admin = community.admins.first()
if admin:
Notification.objects.create(
user=admin,
community=community,
category="communities",
notification_type="article_submitted",
message=(
f"New article submitted in {community.name}"
f" by {request.auth.username}"
),
link=f"/community/{community.name}/submissions",
content=article.title,
)
except Exception:
# Continue even if notification creation fails
pass
Expand Down
36 changes: 20 additions & 16 deletions communities/api_invitation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,13 +186,15 @@ def respond_to_invitation(

# Optional: Send notification to community admin about the decision
try:
Notification.objects.create(
user=invitation.community.admins.first(),
message=f"{request.auth.username} has {payload.action}ed the "
f"invitation to join {invitation.community.name}.",
category="communities",
notification_type="join_request_responded",
)
admin = invitation.community.admins.first()
if admin:
Notification.objects.create(
user=admin,
message=f"{request.auth.username} has {payload.action}ed the "
f"invitation to join {invitation.community.name}.",
category="communities",
notification_type="join_request_responded",
)
except Exception as e:
logger.error(f"Error creating notification: {e}")
# Continue even if notification fails - the invitation was already processed
Expand Down Expand Up @@ -417,15 +419,17 @@ def respond_to_email_invitation(

try:
# Optional: Send notification to community admin about the decision
Notification.objects.create(
user=invitation.community.admins.first(),
message=(
f"{user.username} has {payload.action}ed the "
f"invitation to join {invitation.community.name}."
),
category="communities",
notification_type="join_request_responded",
)
admin = invitation.community.admins.first()
if admin:
Notification.objects.create(
user=admin,
message=(
f"{user.username} has {payload.action}ed the "
f"invitation to join {invitation.community.name}."
),
category="communities",
notification_type="join_request_responded",
)
except Exception as e:
logger.error(f"Error creating notification: {e}")
# Continue even if notification fails - the invitation was already processed
Expand Down
16 changes: 9 additions & 7 deletions communities/api_join.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,13 +119,15 @@ def join_community(request, community_id: int):

# Send a notification to the first admin
try:
Notification.objects.create(
user=community.admins.first(),
community=community,
notification_type="join_request_received",
message=f"New join request from {user.username}",
link=f"/community/{community.name}/requests",
)
admin = community.admins.first()
if admin:
Notification.objects.create(
user=admin,
community=community,
notification_type="join_request_received",
message=f"New join request from {user.username}",
link=f"/community/{community.name}/requests",
)
except Exception as e:
logger.error(f"Error creating notification: {e}")
# Continue even if notification fails
Expand Down
24 changes: 13 additions & 11 deletions communities/articles_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,17 +111,19 @@ def submit_article(request, community_name: str, article_slug: str):

# Send a notification to the community admins
try:
Notification.objects.create(
user=community.admins.first(),
community=community,
category="communities",
notification_type="article_submitted",
message=(
f"New article submitted in {community.name} by {request.auth.username}"
),
link=f"/community/{community.name}/submissions",
content=article.title,
)
admin = community.admins.first()
if admin:
Notification.objects.create(
user=admin,
community=community,
category="communities",
notification_type="article_submitted",
message=(
f"New article submitted in {community.name} by {request.auth.username}"
),
link=f"/community/{community.name}/submissions",
content=article.title,
)
except Exception as e:
logger.error(f"Error creating notification: {e}")
# Continue even if notification fails
Expand Down