fix: update local FFmpeg core version to 0.12.10 to fix export crash#1388
Open
Abhishek2005-ard wants to merge 7 commits into
Open
fix: update local FFmpeg core version to 0.12.10 to fix export crash#1388Abhishek2005-ard wants to merge 7 commits into
Abhishek2005-ard wants to merge 7 commits into
Conversation
|
@Abhishek2005-ard is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @Abhishek2005-ardBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @Abhishek2005-ard!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a critical version mismatch issue that was causing the FFmpeg WASM engine to fail to load when falling back to the locally hosted UMD files.
Previously,
scripts/download_ffmpeg_umd.jswas hardcoded to download@ffmpeg/core@0.12.6, but the application actually uses@ffmpeg/ffmpeg^0.12.10and validates against SRI hashes for0.12.10. This mismatch caused the export process to silently fail or throw WASM loading errors.The download script has been updated to fetch the correct
0.12.10versions of bothffmpeg-core.jsandffmpeg-core.wasm.Changes Made
scripts/download_ffmpeg_umd.jsto change the CDN URL version from@0.12.6to@0.12.10.public/ffmpeg/umd/.Testing Instructions
node scripts/download_ffmpeg_umd.js.npm run dev.close #1384