test: fix Vitest JSX compilation and mock window.matchMedia#1389
Open
Abhishek2005-ard wants to merge 8 commits into
Open
test: fix Vitest JSX compilation and mock window.matchMedia#1389Abhishek2005-ard wants to merge 8 commits into
Abhishek2005-ard wants to merge 8 commits into
Conversation
|
@Abhishek2005-ard is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @Abhishek2005-ard!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @Abhishek2005-ardBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Author
|
@magic-peach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an issue where the test suite was immediately failing with a
vite:import-analysiserror when executing component tests.Since the project delegates JSX transpilation to Next.js (
"jsx": "preserve"intsconfig.json), Vitest required a plugin to understand React.tsxsyntax. Additionally, the JSDOM test environment does not natively supportwindow.matchMedia, which caused theThemeToggle.test.tsxtest to fail once compilation succeeded.Changes Made
@vitejs/plugin-reactas a dev dependency to handle JSX compilation.vitest.config.tsto include the React Vite plugin.window.matchMediainsidevitest.setup.tsto ensure components that utilize media queries (like the theme logic) can be tested properly in JSDOM.Testing Instructions
npm run testornpx vitest.TypeError: window.matchMedia is not a function.close #1385